Skip to content

[INT-78] visual-snapshots: parallel processing of PDF pages #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Mar 20, 2025
Merged

[INT-78] visual-snapshots: parallel processing of PDF pages #205

merged 17 commits into from
Mar 20, 2025

Conversation

perf2711
Copy link
Contributor

@perf2711 perf2711 commented Mar 13, 2025 •
edited
Loading

visual-snapshots: parallel processing of PDF pages

Issue: INT-78

Description

Adds parallel processing of PDF pages using the workerpool library.

Types of Changes

  • New feature (non-breaking change which adds functionality)

@perf2711 perf2711 added enhancement New feature or request javascript Pull requests that update Javascript code labels Mar 13, 2025
paweltomaszewskisaucelabs
paweltomaszewskisaucelabs requested changes Mar 13, 2025
View reviewed changes
@perf2711 perf2711 force-pushed the feat/INT-78/pdf-parallel-processing branch from 6b68d3a to 1287e73 Compare March 14, 2025 16:03
@perf2711 perf2711 self-assigned this Mar 18, 2025
paweltomaszewskisaucelabs
paweltomaszewskisaucelabs approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@paweltomaszewskisaucelabs paweltomaszewskisaucelabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible performance improvement!
Great work, I can't wait to play with it in examples repo.

Base automatically changed from feat/INT-1/jest-esm to feat/INT-1/pdf-snapshots March 20, 2025 14:13
perf2711 added 16 commits March 20, 2025 15:13
@perf2711
[INT-78] visual-snapshots: add parallel processing of PDF files
6159934
@perf2711
[INT-78] visual-snapshots: add parallel processing of PDF pages
fccd9e6
@perf2711
[INT-78] visual-snapshots: fix error behavior for waitForEmptyQueue
90394ff
@perf2711
[INT-78] visual-snapshots: fix visual-api tests, make them more deter…
07fe61d 
…ministic
@perf2711
[INT-78] visual-snapshots: address MR comments
60cbcc1
@perf2711
[INT-78] visual-snapshots: process pages before adding more files
4ba9a63
@perf2711
[INT-78] visual-snapshots: add comment to setImmediate workers
6eec823
@perf2711
[INT-78] visual-snapshots: fix unit tests
0cd5325
@perf2711
[INT-78] visual-snapshots: move processing pdf file pages to workerpool
c5d52b7
@perf2711
[INT-78] visual-snapshots: remove old queue code
a8821f8
@perf2711
[INT-78] visual-snapshots: move clienVersion to a separate file
1eb2a05
@perf2711
[INT-78] visual-snapshots: refactor code, split responsibilities
5312c3e
@perf2711
[INT-78] visual-snapshots: add PdfCommandHandler tests
032efa8
@perf2711
[INT-78] visual-snapshots: rename LoadedPdfFile to PdfFile
d010c9b
@perf2711
[INT-78] visual-snapshots: fix argv missing in worker
9a77a29
@perf2711
[INT-78] visual-snapshots: update path to PKG_VERSION file
57975c2
@perf2711 perf2711 force-pushed the feat/INT-78/pdf-parallel-processing branch from 8f6f09d to 57975c2 Compare March 20, 2025 14:13
@perf2711 perf2711 merged commit 65cddbb into feat/INT-1/pdf-snapshots Mar 20, 2025
1 check passed
@perf2711 perf2711 deleted the feat/INT-78/pdf-parallel-processing branch March 20, 2025 14:49
aga-szczepanska pushed a commit that referenced this pull request Mar 24, 2025
@perf2711 @aga-szczepanska
[INT-78] visual-snapshots: parallel processing of PDF pages (#205)
1636be9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aga-szczepanska aga-szczepanska aga-szczepanska approved these changes

@paweltomaszewskisaucelabs paweltomaszewskisaucelabs paweltomaszewskisaucelabs approved these changes

Assignees

@perf2711 perf2711

Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perf2711 @aga-szczepanska @paweltomaszewskisaucelabs